[RAPPS-DB] Use SaveAs to avoid VC and .NET installer name collisions - #399
Merged
Conversation
binarymaster
changed the title
SaveAs to avoid name collisionsSaveAs to avoid VC and .NET installer name collisions
binarymaster
approved these changes
Jul 28, 2026
Contributor
It was designed for URLs where it does not have .exe or anything sensible in the name but your usage is a nice tweak. |
whindsaks
approved these changes
Jul 28, 2026
Collaborator
|
Good point, really. 👍 |
julenuri
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
I noticed some downloaded files have the same filename. For example,
vc2008sp1runandvc2010sp1runare both namedvcredist_x86.exe. That results in the files of different versions replacing each other after download, so those files can't be kept, even if the user wants to keep them for possible future reinstall.Solution:
The
SaveAsfields are added so that the downloaded files are properly renamed to avoid filename collisions:_vs20xxis added before the extension, following the naming convention found invcredist_arm_vs2015.exe11or20is added before the extension, following the naming convention of the app name.Not sure if this is the intended usage of
SaveAs. It solves the problem tho :)Test:
I have tested locally in applications manager by updating the local appdb. The files are saved in different filenames, and can be installed with, as expected.